feat: create the v059x node-override.yaml via solo #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r the new file Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
…x-network-overrideyml-via-solo
jeromy-cannon
added
the
PR: Checks Failed
Signed-off-by: instamenta <[email protected]>
…x-network-overrideyml-via-solo
…x-network-overrideyml-via-solo
…ia-solo Signed-off-by: Jeromy Cannon <[email protected]>
… to convert the interfaceBindings and endpointOverrides to JSON and to emit them as keys if they are not needed Signed-off-by: instamenta <[email protected]>
…on notation Signed-off-by: instamenta <[email protected]>
jeromy-cannon
added
the
PR: Merge Conflicts
…x-network-overrideyml-via-solo # Conflicts: # src/core/genesis_network_models/genesis_network_data_constructor.ts
…is parameter Signed-off-by: instamenta <[email protected]>
instamenta
removed
the
PR: Merge Conflicts
Signed-off-by: instamenta <[email protected]>
…to avoid throwing error Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
instamenta
changed the title
Signed-off-by: instamenta <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
==========================================
+ Coverage 82.15% 83.12% +0.96%
==========================================
Files 118 119 +1
Lines 22426 22521 +95
Branches 1569 1483 -86
==========================================
+ Hits 18424 18720 +296
+ Misses 3929 3754 -175
+ Partials 73 47 -26
... and 25 files with indirect coverage changes |
JeffreyDallas
added
PR: Needs Approval
…eate-the-v059x-network-overrideyml-via-solo
Signed-off-by: Jeffrey Tang <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
…ttps://github.com/hashgraph/solo into 01151-create-the-v059x-network-overrideyml-via-solo
jeromy-cannon
approved these changes
Feb 8, 2025
jeromy-cannon
deleted the
01151-create-the-v059x-network-overrideyml-via-solo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new class
NodeOverridesModelwhich creates thenode-override.yamlinside the staging directory and then copies it inside the nodes duringnode setupRelated Issues